Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

デフォルトの公開範囲から連合なしを削除 #532

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

kozakura913
Copy link
Collaborator

@kozakura913 kozakura913 commented Nov 5, 2024

What

デフォルトの公開範囲の設定から連合なしを削除

Why

連合なし機能は削除済、機能してない設定項目は紛らわしい

Additional info (optional)

localStorageには残してある

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_YOJO.mdの更新((If needed) Update CHANGELOG_YOJO.md)
  • (必要なら)テストの追加((If possible) Add tests)

@kozakura913 kozakura913 self-assigned this Nov 5, 2024
@kozakura913 kozakura913 added this to the yojo1.1.0 milestone Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.30%. Comparing base (ffe4ce6) to head (4f7f57c).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #532       +/-   ##
============================================
- Coverage    59.90%   20.30%   -39.60%     
============================================
  Files          882      790       -92     
  Lines       102715   118122    +15407     
  Branches      1626     1090      -536     
============================================
- Hits         61529    23987    -37542     
- Misses       41165    93545    +52380     
- Partials        21      590      +569     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozakura913 kozakura913 merged commit c4c1ceb into yojo-art:develop Nov 5, 2024
16 of 17 checks passed
@kozakura913 kozakura913 mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants